Introduce per-tab preferences service.

chrome/test/base/testing_pref_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/base/testing_pref_service.h"
 
 #include "chrome/browser/policy/configuration_policy_pref_store.h"
 #include "chrome/browser/prefs/browser_prefs.h"
 #include "chrome/browser/prefs/command_line_pref_store.h"
 #include "chrome/browser/prefs/default_pref_store.h"
-#include "chrome/browser/prefs/pref_notifier.h"
+#include "chrome/browser/prefs/pref_model_associator.h"
+#include "chrome/browser/prefs/pref_notifier_impl.h"
 #include "chrome/browser/prefs/pref_value_store.h"
 #include "chrome/browser/prefs/testing_pref_store.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 TestingPrefServiceBase::TestingPrefServiceBase(
     TestingPrefStore* managed_platform_prefs,
     TestingPrefStore* user_prefs,
     TestingPrefStore* recommended_platform_prefs)
-    : PrefService(managed_platform_prefs,
-                  NULL,
-                  NULL,
-                  NULL,
+    : PrefService(new PrefNotifierImpl(),
                   user_prefs,
-                  recommended_platform_prefs,
-                  NULL,
                   new DefaultPrefStore(),
+                  new PrefModelAssociator(),

[Mattias Nissler (ping if slow), 2011/11/18 14:57:07]

same here: Do we really need a non-null associator?

[mnaganov (inactive), 2011/11/21 14:52:20]

Not sure, but I trust you. Set to NULL.

[mnaganov (inactive), 2011/11/21 16:36:39]

I have found the reason: ProfileSyncServicePreferenceTest tests require this so
I have added it back.

+                  new PrefValueStore(
+                      managed_platform_prefs,
+                      NULL,
+                      NULL,
+                      NULL,
+                      PrefService::user_pref_store_.get(),

[Mattias Nissler (ping if slow), 2011/11/18 14:57:07]

How can this work? The PrefValueStore ctor() run before the PrefService ctor(),
so I'd expect these references to all return NULL. We'll not segfault, but this
won't pass tests.

[mnaganov (inactive), 2011/11/21 14:52:20]

Oh, right. Of course, call semantics requires arguments to be evaluated first. I
have added more parameters to TestingPrefServiceBase to deal with this
correctly.

+                      recommended_platform_prefs,
+                      NULL,
+                      PrefService::default_store_.get(),
+                      PrefService::pref_sync_associator_.get(),
+                      PrefService::pref_notifier_.get()),
                   false),
       managed_platform_prefs_(managed_platform_prefs),
       user_prefs_(user_prefs),
       recommended_platform_prefs_(recommended_platform_prefs) {
 }
 
 TestingPrefServiceBase::~TestingPrefServiceBase() {
 }
 
 const Value* TestingPrefServiceBase::GetManagedPref(const char* path) const {
@@ skipping 65 matching lines @@
     : browser_process_(browser_process) {
   browser::RegisterLocalState(&local_state_);
   EXPECT_FALSE(browser_process->local_state());
   browser_process->SetLocalState(&local_state_);
 }
 
 ScopedTestingLocalState::~ScopedTestingLocalState() {
   EXPECT_EQ(&local_state_, browser_process_->local_state());
   browser_process_->SetLocalState(NULL);
 }