Introduce per-tab preferences service.

chrome/browser/ui/tab_contents/tab_contents_wrapper.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_
 #define CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 22 matching lines @@
 class ExternalProtocolObserver;
 class FaviconTabHelper;
 class FindTabHelper;
 class InfoBarTabHelper;
 class HistoryTabHelper;
 class NavigationController;
 class OmniboxSearchHint;
 class PasswordManager;
 class PasswordManagerDelegate;
 class PluginObserver;
+class PrefService;
 class Profile;
 class RestoreTabHelper;
 class SadTabObserver;
 class SearchEngineTabHelper;
 class TabContentsSSLHelper;
 class TabContentsWrapperDelegate;
 class TabContentsWrapperSyncedTabDelegate;
 class TabSpecificContentSettings;
 class ThumbnailGenerator;
 class TranslateTabHelper;
@@ skipping 232 matching lines @@
   scoped_ptr<FaviconTabHelper> favicon_tab_helper_;
   scoped_ptr<FindTabHelper> find_tab_helper_;
   scoped_ptr<HistoryTabHelper> history_tab_helper_;
   scoped_ptr<InfoBarTabHelper> infobar_tab_helper_;
 
   // PasswordManager and its delegate. The delegate must outlive the manager,
   // per documentation in password_manager.h.
   scoped_ptr<PasswordManagerDelegate> password_manager_delegate_;
   scoped_ptr<PasswordManager> password_manager_;
 
+  // Allows overriding user preferences per tab.
+  scoped_ptr<PrefService> per_tab_prefs_;

[Avi (use Gerrit), 2011/11/17 18:23:33]

Since there is no getter, this isn't a tab helper and doesn't belong in this
section (see the comment on line 275). Move this to the observer section, line
328 or wherever it fits alphabetically, and move the allocation in the .cc file
too.

[mnaganov (inactive), 2011/11/17 18:27:00]

I'm not yet sure how to use this. I need to override WebKit prefs using
per_tab_prefs_ when getting WebPreferences from TabContents. It will become more
clear when I'll add plumbing to other places.

[mnaganov (inactive), 2011/11/17 19:54:43]

I have moved this into the "observers" section as you suggested.

+
   scoped_ptr<prerender::PrerenderTabHelper> prerender_tab_helper_;
 
   // Handles print job for this contents.
   scoped_ptr<printing::PrintViewManager> print_view_manager_;
 
   scoped_ptr<RestoreTabHelper> restore_tab_helper_;
 
   // Handles displaying a web intents picker to the user.
   scoped_ptr<WebIntentPickerController> web_intent_picker_controller_;
 
@@ skipping 29 matching lines @@
 
   // The supporting objects need to outlive the TabContents dtor (as they may
   // be called upon during its execution). As a result, this must come last
   // in the list.
   scoped_ptr<TabContents> tab_contents_;
 
   DISALLOW_COPY_AND_ASSIGN(TabContentsWrapper);
 };
 
 #endif  // CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_