Issue 8568011: gtk/bookmarks: Reuse |model_| in BookmarkBarGtkUnittest.

Issue 8568011: gtk/bookmarks: Reuse |model_| in BookmarkBarGtkUnittest. (Closed)

Created:
9 years, 1 month ago by tfarina

Modified:
9 years, 1 month ago

Reviewers:
Elliot Glaysher, sky

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gtk/bookmarks: Reuse |model_| in BookmarkBarGtkUnittest. TEST=unit_tests --gtest_filter=BookmarkBarGtkUnittest* R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110193

Patch Set 2 : erg review #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -20 lines)			Patch
	M	chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_unittest.cc	View	1	5 chunks	+19 lines, -20 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

http://codereview.chromium.org/8568011/diff/1/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_unittest.cc File chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_unittest.cc (right): http://codereview.chromium.org/8568011/diff/1/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_unittest.cc#newcode59 chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_unittest.cc:59: scoped_ptr<BookmarkBarGtk> bookmark_bar_; If you're going to make this protected, ...

9 years, 1 month ago (2011-11-15 17:55:59 UTC) #3

tfarina

9 years, 1 month ago (2011-11-15 20:56:26 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/8568011/6003

9 years, 1 month ago (2011-11-15 21:15:37 UTC) #6

Change committed as 110193

Expand Messages | Collapse Messages