Minor build fixes for aura/touchui

Minor build fixes for aura/touchui


BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110233

[sadrul, 2011-11-15 16:34:41]

http://codereview.chromium.org/8568010/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/8568010/diff/1/chrome/chrome_browser.gypi#newc...
chrome/chrome_browser.gypi:4175: ['exclude', '^browser/aeropeek_manager.cc'],
I think you want to move the exclusion rule in this block. I also think you can
exclude all render_widget_host_view_views*, 
native_tab_contents_container_views*, and native_tab_contents_view_views*

[Ian Vollick, 2011-11-15 16:56:40]

On 2011/11/15 16:34:41, sadrul wrote:
> http://codereview.chromium.org/8568010/diff/1/chrome/chrome_browser.gypi
> File chrome/chrome_browser.gypi (right):
> 
>
http://codereview.chromium.org/8568010/diff/1/chrome/chrome_browser.gypi#newc...
> chrome/chrome_browser.gypi:4175: ['exclude', '^browser/aeropeek_manager.cc'],
> I think you want to move the exclusion rule in this block. I also think you
can
> exclude all render_widget_host_view_views*, 
> native_tab_contents_container_views*, and native_tab_contents_view_views*
Done.

[sadrul, 2011-11-15 16:58:38]

http://codereview.chromium.org/8568010/diff/3001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/8568010/diff/3001/chrome/chrome_browser.gypi#n...
chrome/chrome_browser.gypi:4189: ['exclude',
'^browser/renderer_host/render_widget_host_view_views_touch.h'],
I think '../render_widget_host_view_views*' is more appropriate (the rest of
those files are not used either in aura)

[Ian Vollick, 2011-11-15 17:05:46]

On 2011/11/15 16:58:38, sadrul wrote:
> http://codereview.chromium.org/8568010/diff/3001/chrome/chrome_browser.gypi
> File chrome/chrome_browser.gypi (right):
> 
>
http://codereview.chromium.org/8568010/diff/3001/chrome/chrome_browser.gypi#n...
> chrome/chrome_browser.gypi:4189: ['exclude',
> '^browser/renderer_host/render_widget_host_view_views_touch.h'],
> I think '../render_widget_host_view_views*' is more appropriate (the rest of
> those files are not used either in aura)

Done. Sorry, I thought those wildcards were shorthand.

[sadrul, 2011-11-15 17:06:52]

LGTM

(You still need OWNERS)

[Ian Vollick, 2011-11-15 17:27:08]

+sky

[sky, 2011-11-15 17:50:56]

LGTM

[commit-bot: I haz the power, 2011-11-15 19:03:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/8568010/4005

[commit-bot: I haz the power, 2011-11-15 21:17:47]

Try job failure for 8568010-4005 (retry) (retry) on win_rel for step "ui_tests"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...