Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 8568002: Revert 109977 - Implement font fallback in RenderTextWin. (Closed)

Created:
9 years, 1 month ago by alekseys%chromium.org
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 109977 - Implement font fallback in RenderTextWin. This is done by using a metafile to capture the font that Uniscribe would use to render the text (since there is no API to get this from Uniscribe itself). Makes SCRIPT_CACHE be per-run, since different runs may have different fonts and the SCRIPT_CACHE cannot be re-used between these. This is similar to what is done in WebKit in FontCacheWin.cpp BUG=90426 TEST=Run chrome.exe --use-pure-views and paste some Hebrew text into the omnibox. It should show up properly. Review URL: http://codereview.chromium.org/8565011 TBR=asvitkine@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110001

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -82 lines) Patch
MM ui/gfx/render_text_win.h View 3 chunks +4 lines, -3 lines 0 comments Download
MM ui/gfx/render_text_win.cc View 11 chunks +13 lines, -79 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
alekseys%chromium.org
9 years, 1 month ago (2011-11-15 00:47:41 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698