Issue 8568001: Fix FramedBrowserWindowTest.WindowWidgetLocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8568001: Fix FramedBrowserWindowTest.WindowWidgetLocation. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)

Modified:
9 years, 1 month ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix FramedBrowserWindowTest.WindowWidgetLocation on Lion. BUG=103913 TEST=fixing a unit test; test should no longer fail when run on Lion Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110095

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
	M	chrome/browser/ui/cocoa/framed_browser_window_unittest.mm	View		3 chunks	+13 lines, -5 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

9 years, 1 month ago (2011-11-15 15:22:43 UTC) #2

lgtm with nit

http://codereview.chromium.org/8568001/diff/1/chrome/browser/ui/cocoa/framed_...
File chrome/browser/ui/cocoa/framed_browser_window_unittest.mm (right):

http://codereview.chromium.org/8568001/diff/1/chrome/browser/ui/cocoa/framed_...
chrome/browser/ui/cocoa/framed_browser_window_unittest.mm:109:
isKindOfClass:[BrowserWindowController class]];
nit: indent 4

Expand Messages | Collapse Messages