Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8567022: Cleanup: Remove forward declarations in various directories. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
CC:
chromium-reviews, vrk (LEFT CHROMIUM), jam, acolwell+watch_chromium.org, amit, annacc+watch_chromium.org, ajwong+watch_chromium.org, cbentzel+watch_chromium.org, dmaclach+watch_chromium.org, joi+watch-content_chromium.org, wez+watch_chromium.org, darin-cc_chromium.org, ihf+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, dpranke-watch+content_chromium.org, simonmorris+watch_chromium.org, sergeyu+watch_chromium.org, scherkus (not reviewing), jamiewalch+watch_chromium.org, hclam+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Remove forward declarations in various directories. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110631

Patch Set 1 : '' #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -40 lines) Patch
M chrome/common/service_process_util.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome_frame/cfproxy.h View 1 2 chunks +2 lines, -9 lines 0 comments Download
M chrome_frame/chrome_active_document.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome_frame/external_tab.h View 1 1 chunk +8 lines, -6 lines 0 comments Download
M chrome_frame/urlmon_url_request_private.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/host_zoom_map.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/media/audio_message_filter.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/connection_to_client.h View 1 2 chunks +1 line, -5 lines 0 comments Download
M remoting/protocol/jingle_datagram_connector.h View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
9 years, 1 month ago (2011-11-17 05:10:35 UTC) #1
Paweł Hajdan Jr.
LGTM
9 years, 1 month ago (2011-11-17 09:58:43 UTC) #2
scherkus (not reviewing)
in case you need it ... LGTM on *media/ folders
9 years, 1 month ago (2011-11-17 22:45:14 UTC) #3
Wez
LGTM for remoting/, FWIW.
9 years, 1 month ago (2011-11-17 23:34:36 UTC) #4
robertshield
9 years, 1 month ago (2011-11-18 00:56:20 UTC) #5 
On 2011/11/17 23:34:36, Wez wrote:
> LGTM for remoting/, FWIW.

LGTM for CF too. Thanks for doing the cleanup.

Powered by Google App Engine
This is Rietveld 408576698