Limit number of notifications that can be received by the client.

chrome/browser/extensions/app_notification.h

Index: chrome/browser/extensions/app_notification.h
===================================================================
--- chrome/browser/extensions/app_notification.h	(revision 109957)
+++ chrome/browser/extensions/app_notification.h	(working copy)
@@ -21,6 +21,7 @@
   // If |is_local| is true, notification is not synced.
   // If |guid| is empty, a new guid is automatically created.
   AppNotification(bool is_local,
+                  double creation_timestamp_ms,

[Munjal (Google), 2011/11/17 19:45:32]

Is double the right data type for ms since epoch?

[Munjal (Google), 2011/11/17 19:45:32]

Nit: may be just name it creation_time_ms

[asargent_no_longer_on_chrome, 2011/11/17 22:36:24]

Actually it would probably be better to use our Time class (from base/time.h)

[elvin, 2011/11/17 22:52:58]

Done.

                   const std::string& guid,
                   const std::string& extension_id,
                   const std::string& title,
@@ -37,6 +38,7 @@
 
   // Accessors.
   bool is_local() const { return is_local_; }
+  double creation_timestamp_ms() const { return creation_timestamp_ms_; }

[Munjal (Google), 2011/11/17 19:45:32]

Nit: name creation_time_ms()

   const std::string& guid() const { return guid_; }
   const std::string& extension_id() const { return extension_id_; }
   const std::string& title() const { return title_; }
@@ -59,6 +61,7 @@
   // Whether notification is local only, which means it is not synced
   // across machines.
   bool is_local_;
+  double creation_timestamp_ms_;

[Munjal (Google), 2011/11/17 19:45:32]

Nit: same name nit here.

[elvin, 2011/11/17 22:52:58]

Done.

   std::string guid_;
   std::string extension_id_;
   std::string title_;