Limit number of notifications that can be received by the client.

chrome/browser/extensions/extension_app_api.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_app_api.h"
 
 #include "base/values.h"
 #include "chrome/browser/extensions/app_notification_manager.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/extensions/extension.h"
 #include "content/public/browser/notification_service.h"
 
 const char kBodyTextKey[] = "bodyText";
 const char kExtensionIdKey[] = "extensionId";
 const char kLinkTextKey[] = "linkText";
 const char kLinkUrlKey[] = "linkUrl";
 const char kTitleKey[] = "title";
+const char kCreationKey[] = "creation_timestamp_ms";
 
 const char kInvalidExtensionIdError[] =
     "Invalid extension id";
 const char kMissingLinkTextError[] =
     "You must specify linkText if you use linkUrl";
 
 bool AppNotifyFunction::RunImpl() {
   DictionaryValue* details;
   EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(0, &details));
   EXTENSION_FUNCTION_VALIDATE(details != NULL);
 
   // TODO(asargent) remove this before the API leaves experimental.
   std::string id = extension_id();
   if (details->HasKey(kExtensionIdKey)) {
     EXTENSION_FUNCTION_VALIDATE(details->GetString(kExtensionIdKey, &id));
     if (!profile()->GetExtensionService()->GetExtensionById(id, true)) {
       error_ = kInvalidExtensionIdError;
       return false;
     }
   }
 
   std::string title;
   if (details->HasKey(kTitleKey))
     EXTENSION_FUNCTION_VALIDATE(details->GetString(kTitleKey, &title));
 
   std::string body;
   if (details->HasKey(kBodyTextKey))
     EXTENSION_FUNCTION_VALIDATE(details->GetString(kBodyTextKey, &body));
 
+  double creation_timestamp_ms;
+  if (details->HasKey(kCreationKey))
+    EXTENSION_FUNCTION_VALIDATE(details->GetDouble(kCreationKey,
+                                                   &creation_timestamp_ms));

[Munjal (Google), 2011/11/17 19:45:32]

Shouldn't we just fill in creation time ourselves when an extension calls the JS
API to create a notification?

[elvin, 2011/11/17 22:28:17]

Done.

[asargent_no_longer_on_chrome, 2011/11/17 22:36:24]

Yeah, we should just use Time::Now()

[elvin, 2011/11/17 22:52:58]

Done.

+
   scoped_ptr<AppNotification> item(new AppNotification(
-      true, "", id, title, body));
+      true, 0, "", id, title, body));
 
   if (details->HasKey(kLinkUrlKey)) {
     std::string link_url;
     EXTENSION_FUNCTION_VALIDATE(details->GetString(kLinkUrlKey, &link_url));
     item->set_link_url(GURL(link_url));
     if (!item->link_url().is_valid()) {
       error_ = "Invalid url: " + link_url;
       return false;
     }
     if (!details->HasKey(kLinkTextKey)) {
@@ skipping 23 matching lines @@
       error_ = kInvalidExtensionIdError;
       return false;
     }
   }
 
   AppNotificationManager* manager =
       profile()->GetExtensionService()->app_notification_manager();
   manager->ClearAll(id);
   return true;
 }