Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: frog/member.dart

Issue 8567016: Fix a spurious warning in Frog selfhost (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: updated Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/frogsh ('k') | frog/value.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/member.dart
diff --git a/frog/member.dart b/frog/member.dart
index e7c2785b5dff942ce205494f958be0185bc5dd19..d6e56fe61f71747359a01ac3774ff25f84ec88a5 100644
--- a/frog/member.dart
+++ b/frog/member.dart
@@ -1469,6 +1469,10 @@ class MemberSet {
Value returnValue = null;
for (var member in targets) {
final res = member.invoke(context, node, target, args, isDynamic:true);
+ // TODO(jmesserly): If the code has different type checks, it will fail to
+ // unify and go through a dynamic stub. Good so far. However, we'll end
+ // up with a bogus unused temp generated (usually "var $0"). We need a way
+ // to throw away temps when we throw away the code.
returnValue = _tryUnion(returnValue, res, node);
}
« no previous file with comments | « frog/frogsh ('k') | frog/value.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698