Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Issue 8567009: Turn on pure views for pure view omnibox tests (Closed)

Created:
9 years, 1 month ago by oshima
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Turn on pure views for pure view omnibox tests looks like this is regressed in r90978 BUG=none TEST=OmniboxViewViews test will use TextfieldViews Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110102

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
9 years, 1 month ago (2011-11-14 21:38:54 UTC) #1
oshima
9 years, 1 month ago (2011-11-14 21:39:11 UTC) #2
Emmanuel Saint-loubert-Bié
lgtm
9 years, 1 month ago (2011-11-14 21:42:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8567009/1
9 years, 1 month ago (2011-11-14 21:43:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8567009/4001
9 years, 1 month ago (2011-11-15 15:28:13 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 16:40:31 UTC) #6
Change committed as 110102

Powered by Google App Engine
This is Rietveld 408576698