Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 8567002: Fix test setup for TabbedPaneTest. (Closed)

Created:
9 years, 1 month ago by Mattias Nissler (ping if slow)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, dhollowa, Paweł Hajdan Jr., tfarina
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix test setup for TabbedPaneTest. Previously, the test didn't derive from ViewsTestBase, resulting in OLE not getting initialized, which would lead to failure registering drop targets. BUG=chromium:104067 TEST=TabbedPaneTest.* doesn't crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109906

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -19 lines) Patch
M views/controls/tabbed_pane/tabbed_pane_unittest.cc View 6 chunks +7 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mattias Nissler (ping if slow)
Elliot, can you please review? Nicolas: FYI.
9 years, 1 month ago (2011-11-14 12:12:28 UTC) #1
tfarina
On 2011/11/14 12:12:28, Mattias Nissler wrote: > Elliot, can you please review? > Drive-by: Sky ...
9 years, 1 month ago (2011-11-14 12:33:31 UTC) #2
Mattias Nissler (ping if slow)
Adding sky as per tfarina's suggestion.
9 years, 1 month ago (2011-11-14 12:47:10 UTC) #3
sky
LGTM
9 years, 1 month ago (2011-11-14 16:13:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/8567002/1
9 years, 1 month ago (2011-11-14 16:47:18 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-14 18:18:40 UTC) #6
Change committed as 109906

Powered by Google App Engine
This is Rietveld 408576698