Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 8567001: rename some base _linux files to _posix so that others can use it too (Closed)

Created:
9 years, 1 month ago by Robert Nagy
Modified:
9 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

rename some _linux files to _posix and introduce os_bsd The os_bsd variable is only available on FreeBSD and OpenBSD. Later on others like NetBSD and DragonflyBSD can be added. This variable was introduced in order to have shorter conditions in the gyp files. BUG= TEST=compile Patch by Robert Nagy <robert.nagy@gmail.com>; Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109929

Patch Set 1 #

Patch Set 2 : os_bsd #

Patch Set 3 : re-add removed comment #

Patch Set 4 : fix mac failure #

Patch Set 5 : s/c/cc/g and order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -356 lines) Patch
M base/base.gypi View 1 2 3 4 6 chunks +9 lines, -8 lines 0 comments Download
D base/base_paths_linux.cc View 1 chunk +0 lines, -135 lines 0 comments Download
A + base/base_paths_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
D base/native_library_linux.cc View 1 chunk +0 lines, -53 lines 0 comments Download
A + base/native_library_posix.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D base/sys_string_conversions_linux.cc View 1 chunk +0 lines, -161 lines 0 comments Download
A + base/sys_string_conversions_posix.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M build/common.gypi View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Robert Nagy
please review
9 years, 1 month ago (2011-11-14 11:32:06 UTC) #1
Mark Mentovai
Seems fine, LGTM.
9 years, 1 month ago (2011-11-14 13:48:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/8567001/1008
9 years, 1 month ago (2011-11-14 13:59:24 UTC) #3
commit-bot: I haz the power
Presubmit check for 8567001-1008 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-14 13:59:29 UTC) #4
Robert Nagy
On 2011/11/14 13:59:29, I haz the power (commit-bot) wrote: > Presubmit check for 8567001-1008 failed ...
9 years, 1 month ago (2011-11-14 14:00:22 UTC) #5
Mark Mentovai
9 years, 1 month ago (2011-11-14 19:15:48 UTC) #6
Committed r109929 after fixing the copyright year in
base/sys_string_conversions_posix.cc.

Powered by Google App Engine
This is Rietveld 408576698