Issue 8566054: Set up desktop in proper location; fix notification initialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8566054: Set up desktop in proper location; fix notification initialization. (Closed)

Created:
9 years, 1 month ago by stevenjb

Modified:
9 years, 1 month ago

Reviewers:
oshima, Nikita (slow), jam, sky, Nirnimesh

CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Set up desktop in proper location; fix notification initialization. BUG=chromium-os:103427 TEST=See issue

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -33 lines)			Patch
M	chrome/browser/chrome_browser_main.cc	View	5 chunks	+13 lines, -17 lines	0 comments	Download
M	chrome/browser/chrome_browser_parts_aura.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_browser_parts_aura.cc	View	2 chunks	+12 lines, -7 lines	0 comments	Download
M	chrome/browser/chrome_browser_parts_views.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_browser_parts_views.cc	View	2 chunks	+9 lines, -4 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notification_service_factory.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/test/functional/PYAUTO_TESTS	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

stevenjb

This should restore the initialization order of login and fix how notifications were initialized, without ...

9 years, 1 month ago (2011-11-18 22:50:05 UTC) #1

lgtm