Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 8566053: Adding a short-running pyauto-based Angry Birds performance test to perf.py. (Closed)

Created:
9 years, 1 month ago by dennis_jeffrey
Modified:
9 years ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey, krisr, rohitbm
Visibility:
Public.

Description

Adding a short-running pyauto-based Angry Birds performance test to perf.py. The test loads the Angry Birds webapp, lets it run for a minute, then measures CPU utilization and v8 heap size. BUG=chromium-os:23230 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111258

Patch Set 1 #

Patch Set 2 : Minor style edit. #

Total comments: 4

Patch Set 3 : Addressed first round of review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M chrome/test/functional/perf.py View 1 2 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dennis_jeffrey
9 years, 1 month ago (2011-11-18 22:50:57 UTC) #1
Nirnimesh
http://codereview.chromium.org/8566053/diff/2001/chrome/test/functional/perf.py File chrome/test/functional/perf.py (right): http://codereview.chromium.org/8566053/diff/2001/chrome/test/functional/perf.py#newcode1153 chrome/test/functional/perf.py:1153: self.assertTrue(loaded_tab_title.find(url_title_substring) >= 0, better written as: url_title_substring in loaded_tab_title ...
9 years, 1 month ago (2011-11-19 02:31:14 UTC) #2
dennis_jeffrey
Only addressed the review comments; other changes are due to syncing with tip-of-tree. http://codereview.chromium.org/8566053/diff/2001/chrome/test/functional/perf.py File ...
9 years ago (2011-11-22 23:36:37 UTC) #3
Nirnimesh
9 years ago (2011-11-22 23:59:06 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698