Issue 8566046: Fix test_shell_test breakage due to missing SetBufferedBytes expectation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8566046: Fix test_shell_test breakage due to missing SetBufferedBytes expectation (Closed)

Created:
9 years, 1 month ago by vrk (LEFT CHROMIUM)

Modified:
9 years, 1 month ago

Reviewers:
Scott Hess - ex-Googler

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix test_shell_test breakage due to missing SetBufferedBytes expectation SetBufferedBytes may be called independent of having a valid total bytes size for the media element. Update test to reflect this. BUG=NONE TEST=test_shell_tests TBR=acolwell Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110743

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	webkit/media/buffered_data_source_unittest.cc	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LGTM, as I understand things.

Expand Messages | Collapse Messages