Issue 8566041: Allow GLSurface to indicate that it supports a specific extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8566041: Allow GLSurface to indicate that it supports a specific extension. (Closed)

Created:
9 years, 1 month ago by jonathan.backer

Modified:
9 years, 1 month ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Allow GLSurface to indicate that it supports a specific extension. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111147

Patch Set 1 : "" #

Patch Set 2 : Fix gpu_unittests. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -23 lines)			Patch
M	gpu/command_buffer/service/feature_info.cc	View	1	3 chunks	+7 lines, -5 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/gl/gl_context.cc	View		1 chunk	+14 lines, -2 lines	0 comments	Download
M	ui/gfx/gl/gl_surface.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	ui/gfx/gl/gl_surface.cc	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	ui/gfx/gl/gl_surface_egl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/gl/gl_surface_egl.cc	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	ui/gfx/gl/gl_surface_glx.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/gl/gl_surface_glx.cc	View		4 chunks	+13 lines, -5 lines	0 comments	Download
M	webkit/gpu/webgraphicscontext3d_in_process_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jonathan.backer

I'd like to use the same mechanism to plumb a signal (say GL_CHROMIUM_caches_front_buffer) from the ...

9 years, 1 month ago (2011-11-18 19:18:42 UTC) #1

apatrick_chromium

9 years, 1 month ago (2011-11-21 22:17:33 UTC) #2

LGTM. Remember these strings are visible to Pepper. It's probably harmless. With
regard to GL_CHROMIUM_caches_front_buffer, does it have the same semantics as 
EGL_SWAP_BEHAVIOR_PRESERVED_BIT?

Expand Messages | Collapse Messages