Ignore button mouse enter for new tab button

Ignore button mouse enter for new tab button

The new tab button mouse enter is handled in the tab strip controller to ensure
an accurate hover indication (the button is an odd shape).

XIB Changes: Update the new tab button's cell class to the new NewTabButtonCell.

BUG=104326
TEST=Hover over the new tab button, it should light up. Hover slightly to the right of it, it shouldn't light up.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110849

[adinardi, 2011-11-18 03:38:03]

If there's someone more relevant for the review let me know.

[Nico, 2011-11-18 06:33:27]

If you change xib files, please add a "xib changes:" section to the CL
description, see
http://svnsearch.org/svnsearch/repos/CHROMIUM/search?logMessage=xib%20changes

For this patch, you can fill in the TEST= line pretty easily: "TEST=Hover over
the new tab button, it should light up. Hover slightly to the right of it, it
shouldn't light up.". Please do so.

LGTM with those changes and the comment below addressed.

http://codereview.chromium.org/8566036/diff/1/chrome/browser/ui/cocoa/new_tab...
File chrome/browser/ui/cocoa/new_tab_button.mm (right):

http://codereview.chromium.org/8566036/diff/1/chrome/browser/ui/cocoa/new_tab...
chrome/browser/ui/cocoa/new_tab_button.mm:8: // A simple override of the
ImageButtonCell to disable handling of mouseEntered
Comments are sentences and should end with ".". Put a '-' in front of
mouseEntered.

[adinardi, 2011-11-18 22:56:15]

http://codereview.chromium.org/8566036/diff/1/chrome/browser/ui/cocoa/new_tab...
File chrome/browser/ui/cocoa/new_tab_button.mm (right):

http://codereview.chromium.org/8566036/diff/1/chrome/browser/ui/cocoa/new_tab...
chrome/browser/ui/cocoa/new_tab_button.mm:8: // A simple override of the
ImageButtonCell to disable handling of mouseEntered
On 2011/11/18 06:33:27, Nico wrote:
> Comments are sentences and should end with ".". Put a '-' in front of
> mouseEntered.

Done.

[Nico, 2011-11-19 06:32:36]

still lgtm

For lgtms with comments, you don't have to wait for another lgtm, you can just
hit the cq box once you addressed the comments.

[commit-bot: I haz the power, 2011-11-19 07:10:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adinardi@chromium.org/8566036/7001

[commit-bot: I haz the power, 2011-11-19 08:01:20]

Try job failure for 8566036-7001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-11-19 22:38:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adinardi@chromium.org/8566036/7001

[Nico, 2011-11-19 23:18:13]

(I disabled the test that failed on the last run since it failed on all cq jobs.
So this might work this time.)

[commit-bot: I haz the power, 2011-11-19 23:47:04]

Change committed as 110849