Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 8566034: Align expanded panel to the bottom of screen edge when there is an auto-hiding taskbar (Closed)

Created:
9 years, 1 month ago by jianli
Modified:
9 years, 1 month ago
Reviewers:
jennb, Dmitry Titov
CC:
chromium-reviews, jennb, jianli, dcheng, prasadt
Visibility:
Public.

Description

Align expanded panel to the bottom of screen edge when there is an auto-hiding taskbar. BUG=none TEST=existing tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111383

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Merge #

Total comments: 1

Patch Set 4 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M chrome/browser/ui/panels/panel_browser_view_browsertest.cc View 1 6 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/ui/panels/panel_manager.cc View 1 2 3 4 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jianli
9 years, 1 month ago (2011-11-18 01:12:28 UTC) #1
jennb
Drive-by: do any tests need to be updated for this change? If not, should we ...
9 years, 1 month ago (2011-11-18 01:24:41 UTC) #2
Dmitry Titov
I think PanelBrowserViewTest.MinimizeAndRestoreOnAutoHideTaskBar should fail since it verifies the position of the bottom of expanded ...
9 years, 1 month ago (2011-11-18 02:40:01 UTC) #3
Dmitry Titov
I think PanelBrowserViewTest.MinimizeAndRestoreOnAutoHideTaskBar should fail since it verifies the position of the bottom of expanded ...
9 years, 1 month ago (2011-11-18 02:40:03 UTC) #4
jianli
Updated the test. Also fixed one bug in PanelManager where the correct bottom position based ...
9 years, 1 month ago (2011-11-18 20:11:32 UTC) #5
Dmitry Titov
lgtm http://codereview.chromium.org/8566034/diff/6002/chrome/browser/ui/panels/panel_manager.cc File chrome/browser/ui/panels/panel_manager.cc (right): http://codereview.chromium.org/8566034/diff/6002/chrome/browser/ui/panels/panel_manager.cc#newcode545 chrome/browser/ui/panels/panel_manager.cc:545: if (expansion_state == Panel::TITLE_ONLY && I have a ...
9 years, 1 month ago (2011-11-18 21:06:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/8566034/12001
9 years, 1 month ago (2011-11-22 23:28:50 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-23 02:14:26 UTC) #8
Try job failure for 8566034-12001 (previous was lost) (retry) on mac_rel for
steps "browser_tests, ui_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698