Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8566028: Cleanup: Remove more forward declarations in various chrome/browser directories. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
CC:
chromium-reviews, jam, Erik does not do reviews, kkania, mihaip+watch_chromium.org, Aaron Boodman, robertshield, Paweł Hajdan Jr., darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Remove more forward declarations in various chrome/browser directories. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110367

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -74 lines) Patch
M chrome/browser/automation/automation_provider.h View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.h View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/background/background_application_list_model.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/background/background_contents_service.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browser_about_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browser_process_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data_quota_helper.h View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/browsing_data_remover.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/component_updater/flash_component_installer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/debugger/inspectable_tab_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/io_thread.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/notifications/balloon_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/page_info_model.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/plugin_data_remover.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/plugin_observer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/plugin_prefs.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile.h View 5 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 4 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/shell_integration.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sidebar/sidebar_container.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/sidebar/sidebar_manager.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/speech/speech_input_extension_api.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Lei Zhang
9 years, 1 month ago (2011-11-15 08:21:15 UTC) #1
Paweł Hajdan Jr.
LGTM
9 years, 1 month ago (2011-11-15 09:05:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8566028/1
9 years, 1 month ago (2011-11-15 09:12:27 UTC) #3
commit-bot: I haz the power
Presubmit check for 8566028-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-15 09:12:36 UTC) #4
Lei Zhang
+erg for chrome/browser/profile OWNER +cpu for chrome/browser/component_updater OWNER
9 years, 1 month ago (2011-11-15 10:12:37 UTC) #5
Elliot Glaysher
profile lgtm
9 years, 1 month ago (2011-11-15 17:57:27 UTC) #6
cpu_(ooo_6.6-7.5)
component updagter lgtm
9 years, 1 month ago (2011-11-16 21:08:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8566028/1
9 years, 1 month ago (2011-11-16 21:10:49 UTC) #8
commit-bot: I haz the power
9 years, 1 month ago (2011-11-16 22:22:29 UTC) #9 
Change committed as 110367

Powered by Google App Engine
This is Rietveld 408576698