skia/ext/skia_sandbox_support_win.h - Issue 8566026: Implement skia sandbox callback

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: skia/ext/skia_sandbox_support_win.h

Issue 8566026: Implement skia sandbox callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update per code review Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/renderer/renderer_main_platform_delegate_win.cc ('K') | « content/renderer/renderer_main_platform_delegate_win.cc ('k') | skia/ext/skia_sandbox_support_win.cc » ('j') | skia/ext/skia_sandbox_support_win.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef SKIA_EXT_SKIA_SANDBOX_SUPPORT_WIN_H_

	6 #define SKIA_EXT_SKIA_SANDBOX_SUPPORT_WIN_H_

	7 #pragma once

	8

	9 typedef void (*SkiaEnsureTypefaceAccessible)(LOGFONT font);
	vandebo (ex-Chrome) 2011/11/22 18:23:41 predeclare LOGFONT or include the header if you ne predeclare LOGFONT or include the header if you need to. arthurhsu 2011/11/22 20:39:14 Done. Show quoted text On 2011/11/22 18:23:41, vandebo wrote: > predeclare LOGFONT or include the header if you need to. Done.
	10

	11 static SkiaEnsureTypefaceAccessible g_skia_ensure_typeface_accessible;
	jam 2011/11/22 18:16:58 don't need to expose this? don't need to expose this? vandebo (ex-Chrome) 2011/11/22 18:23:41 Move the static to the .cc file? Move the static to the .cc file? arthurhsu 2011/11/22 20:39:14 Done. Show quoted text On 2011/11/22 18:16:58, John Abd-El-Malek wrote: > don't need to expose this? Done. arthurhsu 2011/11/22 20:39:14 Done. Show quoted text On 2011/11/22 18:23:41, vandebo wrote: > Move the static to the .cc file? Done.
	12

	13 SK_API void SetSkiaEnsureTypefaceAccessible(SkiaEnsureTypefaceAccessible);
	vandebo (ex-Chrome) 2011/11/22 18:23:41 Give the argument a name. Give the argument a name. arthurhsu 2011/11/22 20:39:14 Done. Show quoted text On 2011/11/22 18:23:41, vandebo wrote: > Give the argument a name. Done.
	14

	15 #endif // SKIA_EXT_SKIA_SANDBOX_SUPPORT_WIN_H_

OLD	NEW