Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 8566018: Cope with a race condition in NetworkActionPredictor and NetworkActionPredictorDB initialization. (Closed)

Created:
9 years, 1 month ago by dominich
Modified:
9 years, 1 month ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su, Paweł Hajdan Jr.
Visibility:
Public.

Description

Cope with a race condition in NetworkActionPredictor and NetworkActionPredictorDB initialization. BUG=104124 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110119

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adding newline for consistency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M chrome/browser/autocomplete/autocomplete_browsertest.cc View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/autocomplete/network_action_predictor_database.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
dominich
This was happening as the NAP destructor was being triggered from the browser test before ...
9 years, 1 month ago (2011-11-14 22:25:53 UTC) #1
Peter Kasting
LGTM http://codereview.chromium.org/8566018/diff/1/chrome/browser/autocomplete/network_action_predictor_database.cc File chrome/browser/autocomplete/network_action_predictor_database.cc (right): http://codereview.chromium.org/8566018/diff/1/chrome/browser/autocomplete/network_action_predictor_database.cc#newcode92 chrome/browser/autocomplete/network_action_predictor_database.cc:92: if (canceled_.IsSet()) Nit: Looks like your practice elsewhere ...
9 years, 1 month ago (2011-11-14 22:49:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominich@chromium.org/8566018/3001
9 years, 1 month ago (2011-11-15 15:32:00 UTC) #3
commit-bot: I haz the power
Try job failure for 8566018-3001 (retry) on mac_rel for step "ui_tests". It's a second try, ...
9 years, 1 month ago (2011-11-15 17:01:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominich@chromium.org/8566018/3001
9 years, 1 month ago (2011-11-15 17:24:39 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 18:23:45 UTC) #6
Change committed as 110119

Powered by Google App Engine
This is Rietveld 408576698