Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 8566014: Cocoa: Make HTMLDialogWindow resizable (Closed)

Created:
9 years, 1 month ago by sail
Modified:
9 years, 1 month ago
Reviewers:
Nico, akalin
CC:
chromium-reviews, Ben Goodger (Google)
Visibility:
Public.

Description

Cocoa: Make HTMLDialogWindow resizable Currently the Windows HTMLDialogWindow is resizable but the Mac version is not. With this CL I'm matching the Windows behavior and making the dialog resizable with a minimum size of HtmlDialogUIDelegate::GetDialogSize(). BUG=100921 TEST=Open the task manager and verified that the dialog could be resized. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110098

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/browser/ui/cocoa/html_dialog_window_controller.mm View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sail
9 years, 1 month ago (2011-11-14 19:49:58 UTC) #1
Nico
I'll leave this to akalin. Ben, I thought I remember you saying that HTMLDialogWindow should ...
9 years, 1 month ago (2011-11-14 19:57:54 UTC) #2
Ben Goodger (Google)
I am not quite sure what I meant by that. I do think some part ...
9 years, 1 month ago (2011-11-14 20:39:18 UTC) #3
Nico
akalin seems to be out? LGTM in that case.
9 years, 1 month ago (2011-11-15 08:27:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/8566014/1
9 years, 1 month ago (2011-11-15 14:55:50 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 16:34:49 UTC) #6
Change committed as 110098

Powered by Google App Engine
This is Rietveld 408576698