Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 8566012: Allow cross-origin requests for relay http requests made in Transport API. (Closed)

Created:
9 years, 1 month ago by Sergey Ulanov
Modified:
9 years, 1 month ago
Reviewers:
Wez
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org, Jamie
Visibility:
Public.

Description

Allow cross-origin requests for relay http requests made in Transport API. Currently, when creating relay sessions the Transport API can make cross-origin http requests only when the web app has explicit access to the relay domain. This is not really neccessary because Transport API can only be used by chromoting client plugin which is trusted. PPB_URLLoader API allows cross-origin requests for trusted plugins, so Transport API should be allowed to make them too. Changed API implementation to allow cross-origin requests. BUG=103992, 104195 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109973

Patch Set 1 : - #

Total comments: 1

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M content/renderer/p2p/port_allocator.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Sergey Ulanov
9 years, 1 month ago (2011-11-14 18:57:59 UTC) #1
Sergey Ulanov
+jamie
9 years, 1 month ago (2011-11-14 19:51:35 UTC) #2
Wez
LGTM http://codereview.chromium.org/8566012/diff/2001/content/renderer/p2p/port_allocator.cc File content/renderer/p2p/port_allocator.cc (right): http://codereview.chromium.org/8566012/diff/2001/content/renderer/p2p/port_allocator.cc#newcode182 content/renderer/p2p/port_allocator.cc:182: // when this code can be used by ...
9 years, 1 month ago (2011-11-14 21:00:47 UTC) #3
Sergey Ulanov
On 2011/11/14 21:00:47, Wez wrote: > LGTM > > http://codereview.chromium.org/8566012/diff/2001/content/renderer/p2p/port_allocator.cc > File content/renderer/p2p/port_allocator.cc (right): > ...
9 years, 1 month ago (2011-11-14 21:36:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/8566012/5001
9 years, 1 month ago (2011-11-14 21:39:19 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-14 22:56:46 UTC) #6
Change committed as 109973

Powered by Google App Engine
This is Rietveld 408576698