Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 8566011: Completes the GetWindowRect/GetRootWindowRect/GetScreenInfo changes I thought I had finished with... (Closed)

Created:
9 years, 1 month ago by Ben Goodger (Google)
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, yusukes+watch_chromium.org, ajwong+watch_chromium.org, jam, penghuang+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, James Su
Visibility:
Public.

Description

Completes the GetWindowRect/GetRootWindowRect/GetScreenInfo changes I thought I had finished with my last CL. . Disable a check in BrowserMessageFilter that these messages are not handled on the UI thread, for Aura. In Aura, these messages need to be handled on the UI thread (since aura::Windows are not threadsafe). We do not have the NPAPI plugin constraints regular windows has, so this check is not important. . Properly handle these messages in RWH, by sprinkling in some more defined(USE_AURA) to go with the defined(OS_POSIX). . Properly define RenderWidgetHostView::GetDefaultScreenInfo() (it was being done as an override to a static?.. oops). . Get rid of the USE_AURA NOTIMPLEMENTED() definition of the above in render_widget_host_view.cc, replacing with an impl in rwhva.cc. Also moves the _mac and _touch variants to their own .mm/.cc files. . Gets rid of WillWmDestroy for Aura. It's normal-windows-only. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109965

Patch Set 1 #

Patch Set 2 : '' #

Messages

Total messages: 4 (0 generated)
Ben Goodger (Google)
9 years, 1 month ago (2011-11-14 18:36:49 UTC) #1
Ben Goodger (Google)
9 years, 1 month ago (2011-11-14 18:40:23 UTC) #2
Ben Goodger (Google)
On 2011/11/14 18:40:23, Ben Goodger (Google) wrote: As it happens, it's not possible to move ...
9 years, 1 month ago (2011-11-14 19:05:31 UTC) #3
sky
9 years, 1 month ago (2011-11-14 21:20:29 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698