Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 8566009: Remove hidden prototype for builtin functions. (Closed)

Created:
9 years, 1 month ago by Michael Starzinger
Modified:
9 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Remove hidden prototype for builtin functions. This is a deliberate non-conformity introduced more than 2 years ago to be compatible with JSC. The current state is that all other browsers perform ES5 conform in that regard. R=erik.corry@gmail.com BUG=chromium:1717, chromium:39662 TEST=test262/15.2.3.6-4-6??,mjsunit/undeletable-functions Committed: http://code.google.com/p/v8/source/detail?r=9993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -339 lines) Patch
M src/array.js View 1 chunk +1 line, -1 line 0 comments Download
M src/collection.js View 2 chunks +3 lines, -3 lines 0 comments Download
M src/date.js View 1 chunk +1 line, -1 line 0 comments Download
M src/math.js View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/runtime.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M src/string.js View 1 chunk +1 line, -1 line 0 comments Download
M src/v8natives.js View 1 chunk +0 lines, -12 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +54 lines, -0 lines 0 comments Download
D test/mjsunit/regress/regress-91517.js View 1 chunk +0 lines, -112 lines 0 comments Download
M test/mjsunit/undeletable-functions.js View 6 chunks +6 lines, -32 lines 0 comments Download
M test/sputnik/sputnik.status View 1 chunk +0 lines, -47 lines 0 comments Download
M test/test262/test262.status View 3 chunks +0 lines, -84 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
PTAL.
9 years, 1 month ago (2011-11-14 17:40:15 UTC) #1
Erik Corry
LGTM :-)
9 years, 1 month ago (2011-11-14 20:18:40 UTC) #2
Lasse Reichstein
Please check whether this also fixed issue 1623.
9 years, 1 month ago (2011-11-18 21:41:57 UTC) #3
Michael Starzinger
9 years, 1 month ago (2011-11-21 08:41:15 UTC) #4
Indeed it does, updated issue accordingly.

Powered by Google App Engine
This is Rietveld 408576698