Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 8565036: Set the profiler's thread name at a central place (Closed)

Created:
9 years, 1 month ago by jar (doing other things)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, jam, dpranke-watch+content_chromium.org, rvargas (doing something else)
Visibility:
Public.

Description

Set the profiler's thread name at a central place This will automatically catch thread names in several of the child processes we are after, and it also catches the name for a webkcore thread. The underlying function uses a try/catch clause, which contaminates the entire function. As a result, I needed to factor out that section, so that I could still call to set the profiler thread name. Without this, the shared dbg build will fail to compile. r=rtenneti Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110003

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M base/threading/platform_thread_posix.cc View 1 3 chunks +3 lines, -0 lines 0 comments Download
M base/threading/platform_thread_win.cc View 1 2 3 chunks +18 lines, -11 lines 0 comments Download
M base/threading/thread.cc View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jar (doing other things)
Sky: Please rubber stamp minor content change. Raman: Please review this relanding (with a subtle ...
9 years, 1 month ago (2011-11-15 00:49:22 UTC) #1
sky
Rubber stamp LGTM
9 years, 1 month ago (2011-11-15 00:56:59 UTC) #2
Ben Goodger (Google)
lgtm
9 years, 1 month ago (2011-11-15 01:00:41 UTC) #3
ramant (doing other things)
9 years, 1 month ago (2011-11-15 01:14:30 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698