Fixing ProfileManagerTest to use the TestingProfile instead of a real profile. This will allow ea...

chrome/browser/profiles/profile_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class keeps track of the currently-active profiles in the runtime.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_
 #pragma once
 
@@ skipping 180 matching lines @@
   void RegisterTestingProfile(Profile* profile, bool addToCache);
 
   const FilePath& user_data_dir() const { return user_data_dir_; }
 
  protected:
   // Does final initial actions.
   virtual void DoFinalInit(Profile* profile, bool go_off_the_record);
   virtual void DoFinalInitForServices(Profile* profile, bool go_off_the_record);
   virtual void DoFinalInitLogging(Profile* profile);
 
-  // Creates a new profile. Virtual so that unittests can return TestingProfile.
+  // Creates a new profile. Virtual so that unittests can return a
+  // TestingProfile.
   virtual Profile* CreateProfile(const FilePath& path);
 
+  // Creates a new profile asynchronously. Virtual so that unittests can return
+  // a TestingProfile.
+  virtual Profile* CreateAsyncProfile(const FilePath& path,

[Miranda Callahan, 2011/11/21 15:31:31]

I think making an asynchronous creation method analogous to CreateProfile, as
you've done here, is the right way to go, but I'm a bit worried about the
naming. With this method, we now have "CreateProfileAsync" and
"CreateAsyncProfile", and neither the names nor the comments are sufficient to
distinguish what's happening here -- they both basically say "create profile
asynchronously." Can you refactor the naming and comments to be more explicit,
so that it's clear what the different roles of these two methods are? 

[rpetterson, 2011/11/21 22:59:30]

I see your point. I renamed the helper functions to CreateProfileHelper and
CreateProfileAsyncHelper which should hopefully make their designation as simple
helper functions clearer. I also added more to the comments.

+                                      Delegate* delegate);
+
  private:
   friend class TestingProfileManager;
   FRIEND_TEST(ProfileManagerBrowserTest, DeleteAllProfiles);
 
   // This struct contains information about profiles which are being loaded or
   // were loaded.
   struct ProfileInfo {
     ProfileInfo(Profile* profile, bool created)
         : profile(profile), created(created) {
     }
@@ skipping 71 matching lines @@
 class ProfileManagerWithoutInit : public ProfileManager {
  public:
   explicit ProfileManagerWithoutInit(const FilePath& user_data_dir);
 
  protected:
   virtual void DoFinalInitForServices(Profile*, bool) OVERRIDE {}
   virtual void DoFinalInitLogging(Profile*) OVERRIDE {}
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_