Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3170)

Unified Diff: base/threading/worker_pool_posix.cc

Issue 8565024: base: Refactor PendingTask out of MessageLoop. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Style and build fix. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/threading/worker_pool_posix.cc
diff --git a/base/threading/worker_pool_posix.cc b/base/threading/worker_pool_posix.cc
index 886a5475a5987ae4aa29cb9988d06c78844e18f8..c19c00a4bdabffff6c12c93572c8724cce7385a6 100644
--- a/base/threading/worker_pool_posix.cc
+++ b/base/threading/worker_pool_posix.cc
@@ -15,6 +15,8 @@
#include "base/threading/worker_pool.h"
#include "base/tracked_objects.h"
+using tracked_objects::TrackedTime;
+
namespace base {
namespace {
@@ -82,20 +84,20 @@ void WorkerThread::ThreadMain() {
PlatformThread::SetName(name.c_str());
for (;;) {
- PosixDynamicThreadPool::PendingTask pending_task = pool_->WaitForTask();
+ PendingTask pending_task = pool_->WaitForTask();
if (pending_task.task.is_null())
break;
UNSHIPPED_TRACE_EVENT2("task", "WorkerThread::ThreadMain::Run",
"src_file", pending_task.posted_from.file_name(),
"src_func", pending_task.posted_from.function_name());
- tracked_objects::TrackedTime start_time =
+ TrackedTime start_time =
tracked_objects::ThreadData::NowForStartOfRun();
pending_task.task.Run();
tracked_objects::ThreadData::TallyRunOnWorkerThreadIfTracking(
- pending_task.birth_tally, pending_task.time_posted,
+ pending_task.birth_tally, TrackedTime(pending_task.time_posted),
start_time, tracked_objects::ThreadData::NowForEndOfRun());
}
@@ -117,18 +119,6 @@ bool WorkerPool::PostTask(const tracked_objects::Location& from_here,
return true;
}
-PosixDynamicThreadPool::PendingTask::PendingTask(
- const tracked_objects::Location& posted_from,
- const base::Closure& task)
- : posted_from(posted_from),
- task(task) {
- birth_tally = tracked_objects::ThreadData::TallyABirthIfActive(posted_from);
- time_posted = tracked_objects::ThreadData::Now();
-}
-
-PosixDynamicThreadPool::PendingTask::~PendingTask() {
-}
-
PosixDynamicThreadPool::PosixDynamicThreadPool(
const std::string& name_prefix,
int idle_seconds_before_exit)
@@ -197,7 +187,7 @@ void PosixDynamicThreadPool::AddTask(PendingTask* pending_task) {
}
}
-PosixDynamicThreadPool::PendingTask PosixDynamicThreadPool::WaitForTask() {
+PendingTask PosixDynamicThreadPool::WaitForTask() {
AutoLock locked(lock_);
if (terminated_)

Powered by Google App Engine
This is Rietveld 408576698