base: Refactor PendingTask out of MessageLoop.

base/pending_task.h

Index: base/pending_task.h
diff --git a/base/pending_task.h b/base/pending_task.h
new file mode 100644
index 0000000000000000000000000000000000000000..3ca7891b4e32d0fe1af3159e01045138e879c407
--- /dev/null
+++ b/base/pending_task.h
@@ -0,0 +1,56 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PENDING_TASK_H_
+#define PENDING_TASK_H_
+#pragma once
+
+#include <queue>
+
+#include "base/callback.h"
+#include "base/location.h"
+#include "base/time.h"
+#include "base/tracking_info.h"
+
+namespace base {
+
+// Contains data about a pending task. Stored in TaskQueue and DelayedTaskQueue
+// for use by classes that queue and execute tasks.
+struct PendingTask : public base::TrackingInfo {

[willchan no longer on Chromium, 2011/11/14 22:05:55]

base:: is unnecessary throughout this file.

[James Hawkins, 2011/11/15 22:02:49]

Done.

+  PendingTask(const tracked_objects::Location& posted_from,
+              const base::Closure& task);
+  PendingTask(const tracked_objects::Location& posted_from,
+              const base::Closure& task,
+              base::TimeTicks delayed_run_time,
+              bool nestable);
+  ~PendingTask();
+
+  // Used to support sorting.
+  bool operator<(const PendingTask& other) const;
+
+  // The task to run.
+  base::Closure task;
+
+  // The site this PendingTask was posted from.
+  tracked_objects::Location posted_from;
+
+  // Secondary sort key for run time.
+  int sequence_num;
+
+  // OK to dispatch from a nested loop.
+  bool nestable;
+};
+
+// Wrapper around std::queue specialized for PendingTask which adds a Swap
+// helper method.
+class TaskQueue : public std::queue<PendingTask> {
+ public:
+  void Swap(TaskQueue* queue);
+};
+
+typedef std::priority_queue<PendingTask> DelayedTaskQueue;

[willchan no longer on Chromium, 2011/11/14 22:05:55]

Can you rename this to OrderedTaskQueue or something? DelayedTaskQueue is
specific to MessageLoop's use. Actually, perhaps you should just put this
directly in MessageLoop, since it's not used anywhere else.

[James Hawkins, 2011/11/15 22:02:49]

Done.

+
+}  // namespace base
+
+#endif  // PENDING_TASK_H_