Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 8565020: Updating the Flapper version number (Closed)

Created:
9 years, 1 month ago by rohitbm
Modified:
9 years, 1 month ago
Reviewers:
krisr, Nirnimesh
CC:
chromium-reviews, krisr
Visibility:
Public.

Description

Updating the Flapper version number for PyAuto plugins verification test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109945

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M data/chromeos_plugins_list.txt View 1 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rohitbm
9 years, 1 month ago (2011-11-14 19:50:52 UTC) #1
krisr
http://codereview.chromium.org/8565020/diff/1/data/chromeos_plugins_list.txt File data/chromeos_plugins_list.txt (right): http://codereview.chromium.org/8565020/diff/1/data/chromeos_plugins_list.txt#newcode9 data/chromeos_plugins_list.txt:9: u'boards': ['x86-mario', 'x86-alex', 'x86-zgb'], should we add stumpy? I ...
9 years, 1 month ago (2011-11-14 20:02:50 UTC) #2
Nirnimesh
LGTM
9 years, 1 month ago (2011-11-14 20:20:40 UTC) #3
rohitbm
On 2011/11/14 20:20:40, Nirnimesh wrote: > LGTM I have enabled stumpy. Could you recheck?
9 years, 1 month ago (2011-11-14 20:22:45 UTC) #4
krisr
lgtm
9 years, 1 month ago (2011-11-14 20:24:03 UTC) #5
Nirnimesh
9 years, 1 month ago (2011-11-14 20:25:15 UTC) #6
http://codereview.chromium.org/8565020/diff/1/data/chromeos_plugins_list.txt
File data/chromeos_plugins_list.txt (right):

http://codereview.chromium.org/8565020/diff/1/data/chromeos_plugins_list.txt#...
data/chromeos_plugins_list.txt:9: u'boards': ['x86-mario', 'x86-alex',
'x86-zgb'],
On 2011/11/14 20:02:50, krisr wrote:
> should we add stumpy?  I think we have them in the lab now.
+1
Also the EC version# needs to be put in for stumpy -- that test is failing

Powered by Google App Engine
This is Rietveld 408576698