Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 8565015: Avoid trying to layout the desktop when its size is set to 0x0 when minimized on Windows. (Closed)

Created:
9 years, 1 month ago by Ben Goodger (Google)
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Grab-bag: . Avoid trying to layout the desktop when its size is set to 0x0 when minimized on Windows. . Don't show the "Default Browser" UI in Aura either. . Don't flash the active window inactive briefly when clicking on launcher items. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109966 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110116

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M chrome/browser/defaults.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download
M ui/aura/desktop.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/desktop.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M ui/aura/desktop_host_win.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M ui/aura/window_unittest.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ben Goodger (Google)
9 years, 1 month ago (2011-11-14 18:34:53 UTC) #1
sky
http://codereview.chromium.org/8565015/diff/1/ui/aura/desktop.cc File ui/aura/desktop.cc (right): http://codereview.chromium.org/8565015/diff/1/ui/aura/desktop.cc#newcode326 ui/aura/desktop.cc:326: if (!window) Don't we use this to clear the ...
9 years, 1 month ago (2011-11-14 21:12:21 UTC) #2
sky
Ben clarified we explicitly set active_window_ to NULL when deleted, so LGTM
9 years, 1 month ago (2011-11-14 22:16:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/8565015/7001
9 years, 1 month ago (2011-11-15 16:45:22 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 18:07:51 UTC) #5
Change committed as 110116

Powered by Google App Engine
This is Rietveld 408576698