NTP4: Remove native focus emulation for bubbles when explictly told to.

chrome/browser/resources/shared/js/cr/ui/bubble.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // require: event_tracker.js
 
 cr.define('cr.ui', function() {
 
   // The arrow location specifies how the arrow and bubble are positioned in
   // relation to the anchor node.
@@ skipping 72 matching lines @@
 
     /**
      * Handles close event which is triggered when the close button
      * is clicked. By default is set to this.hide.
      * @param {function} A function with no parameters
      */
     set handleCloseEvent(func) {
       this.handleCloseEvent_ = func;
     },
 
+    captureFocus_: true,

[Evan Stade, 2011/11/14 19:20:52]

meh, you can probably just assume this should always be true, i.e. not add this
variable at all but just remove the stopPropagation stuff.

[Dan Beam, 2011/11/15 04:15:10]

Done.

+
+    /**
+     * Tells the bubble whether it should attempt to capture focus like native
+     * dialog UI (i.e. wrench menu).
+     * @param {boolean} capture Whether or not to capture focus.
+     */
+    set captureFocus(capture) {
+      this.captureFocus_ = !!capture;
+    },
+
     /**
      * Sets the anchor node, i.e. the node that this bubble points at.
      * @param {HTMLElement} node The new anchor node.
      */
     set anchorNode(node) {
       this.anchorNode_ = node;
 
       if (!this.hidden)
         this.reposition();
     },
@@ skipping 63 matching lines @@
             anchorMid - ARROW_OFFSET_X;
       }
       var top = this.isTop_ ? clientRect.bottom + ARROW_OFFSET_Y :
           clientRect.top - this.clientHeight - ARROW_OFFSET_Y;
 
       this.style.left = left + 'px';
       this.style.top = top + 'px';
     },
 
     /**
      * Starts showing the bubble. The bubble will grab input and show until the

[Evan Stade, 2011/11/14 19:20:52]

also remove the "grab input" part of this comment

[Dan Beam, 2011/11/15 04:15:10]

Done.

      * user clicks away.
      */
     show: function() {
       if (!this.hidden)
         return;
 
       document.body.appendChild(this);
       this.hidden = false;
       this.reposition();
       this.showTime_ = Date.now();
@@ skipping 33 matching lines @@
           } else if (!this.contains(e.target)) {
             if (Date.now() - this.showTime_ < this.deactivateToDismissDelay_)
               return;
             this.hide();
           } else {
             return;
           }
           break;
       }
 
-      e.stopPropagation();
-      e.preventDefault();
+      if (this.captureFocus_) {
+        e.stopPropagation();
+        e.preventDefault();
+      }
+
       return;
     },
   };
 
   return {
     ArrowLocation : ArrowLocation,
     Bubble : Bubble,
     BubbleAlignment : BubbleAlignment
   };
 });