NTP4: Remove native focus emulation for bubbles when explictly told to.

NTP4: Remove native focus emulation for bubbles when explictly told to.

R=estade@chromium.org
BUG=none
TEST=Starting to drag a tile on NTP4 works when bubble is showing (and hides the
bubble without issue).


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110053

[Evan Stade, 2011-11-14 19:20:52]

http://codereview.chromium.org/8565014/diff/1/chrome/browser/resources/shared...
File chrome/browser/resources/shared/js/cr/ui/bubble.js (right):

http://codereview.chromium.org/8565014/diff/1/chrome/browser/resources/shared...
chrome/browser/resources/shared/js/cr/ui/bubble.js:93: captureFocus_: true,
meh, you can probably just assume this should always be true, i.e. not add this
variable at all but just remove the stopPropagation stuff.

http://codereview.chromium.org/8565014/diff/1/chrome/browser/resources/shared...
chrome/browser/resources/shared/js/cr/ui/bubble.js:187: * Starts showing the
bubble. The bubble will grab input and show until the
also remove the "grab input" part of this comment

[Dan Beam, 2011-11-15 04:15:10]

http://codereview.chromium.org/8565014/diff/1/chrome/browser/resources/shared...
File chrome/browser/resources/shared/js/cr/ui/bubble.js (right):

http://codereview.chromium.org/8565014/diff/1/chrome/browser/resources/shared...
chrome/browser/resources/shared/js/cr/ui/bubble.js:93: captureFocus_: true,
On 2011/11/14 19:20:52, Evan Stade wrote:
> meh, you can probably just assume this should always be true, i.e. not add
this
> variable at all but just remove the stopPropagation stuff.

Done.

http://codereview.chromium.org/8565014/diff/1/chrome/browser/resources/shared...
chrome/browser/resources/shared/js/cr/ui/bubble.js:187: * Starts showing the
bubble. The bubble will grab input and show until the
On 2011/11/14 19:20:52, Evan Stade wrote:
> also remove the "grab input" part of this comment

Done.

[Evan Stade, 2011-11-15 04:23:17]

lgtm

[commit-bot: I haz the power, 2011-11-15 06:14:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/8565014/4001

[commit-bot: I haz the power, 2011-11-15 07:25:39]

Change committed as 110053

[Evan Stade, 2011-11-15 17:18:00]

p.s. you should have changed the CL description before commit. oh well.