Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 8565013: Fix DEPS rules post r109894. (Closed)

Created:
9 years, 1 month ago by Jói
Modified:
9 years, 1 month ago
Reviewers:
tfarina, kmadhusu1, kmadhusu
CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Fix DEPS rules post r109894. TBR=kmadhusu BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
A ui/views/accessibility/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jói
Checking in right away so we can reopen. tfarina: If there's any cleanup to perform ...
9 years, 1 month ago (2011-11-14 16:46:59 UTC) #1
tfarina
On 2011/11/14 16:46:59, Jói wrote: > Checking in right away so we can reopen. > ...
9 years, 1 month ago (2011-11-14 16:48:30 UTC) #2
kmadhusu
lgtm
9 years, 1 month ago (2011-11-14 16:50:30 UTC) #3
kmadhusu1
tfarina, Please run the trybots before checking in any changes and please be on irc. ...
9 years, 1 month ago (2011-11-14 16:50:35 UTC) #4
tfarina
On Mon, Nov 14, 2011 at 2:49 PM, Kausalya Madhusudhanan <kmadhusu@google.com> wrote: > tfarina, > ...
9 years, 1 month ago (2011-11-14 16:51:21 UTC) #5
kmadhusu1
9 years, 1 month ago (2011-11-14 16:52:59 UTC) #6
On Mon, Nov 14, 2011 at 8:51 AM, Thiago Farina <tfarina@chromium.org> wrote:

> On Mon, Nov 14, 2011 at 2:49 PM, Kausalya Madhusudhanan
> <kmadhusu@google.com> wrote:
> > tfarina,
> > Please run the trybots before checking in any changes and please be on
> irc.
> These checkdeps are not running on trybots and I run all my changes
> through trybots. ;)
>
> I just forgot about it :(
>
> np. Thanks.


>  > Thanks.
> > On Mon, Nov 14, 2011 at 8:48 AM, <tfarina@chromium.org> wrote:
> >>
> >> On 2011/11/14 16:46:59, Jói wrote:
> >>>
> >>> Checking in right away so we can reopen.
> >>
> >>> tfarina:  If there's any cleanup to perform (e.g. old rule that can now
> >>> be
> >>> removed) please take care of that, and run tools/checkdeps/checkdeps.py
> >>> before
> >>> committing.
> >>
> >> Ah, yeah, I forgot about it again. Sorry. I'll remember next time.
> Thanks.
> >>
> >> lgtm!
> >>>
> >>> Cheers,
> >>> Jói
> >>
> >>
> >>
> >> http://codereview.chromium.org/8565013/
> >
> >
>
>
>
> --
> Thiago
>

Powered by Google App Engine
This is Rietveld 408576698