Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 8565010: Skia DEPS roll 2666->2674 (Closed)

Created:
9 years, 1 month ago by epoger
Modified:
9 years, 1 month ago
Reviewers:
caryclark, reed1
CC:
chromium-reviews, skia-dev_google.com, reed1
Visibility:
Public.

Description

Skia DEPS roll 2666->2674 Control group (whitespace trybots) is http://codereview.chromium.org/8533009 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109926

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
I will request a review once I get enough trybot results to evaluate the roll.
9 years, 1 month ago (2011-11-14 15:37:15 UTC) #1
reed1
WCPGW -- what could possibly go wrong LGTM
9 years, 1 month ago (2011-11-14 15:39:35 UTC) #2
epoger
On 2011/11/14 15:39:35, reed1 wrote: > WCPGW -- what could possibly go wrong > LGTM ...
9 years, 1 month ago (2011-11-14 15:42:05 UTC) #3
epoger
The trybots seem mostly successful (summary below). My only concerns are the failures in linux_layout ...
9 years, 1 month ago (2011-11-14 17:43:59 UTC) #4
epoger
9 years, 1 month ago (2011-11-14 17:55:04 UTC) #5
Fired off a new set of trybots (both to retry failures we saw, and to check
against new webkit revision)

Powered by Google App Engine
This is Rietveld 408576698