Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: tests/corelib/test_config.dart

Issue 8565006: tools/test.dart: Enable // DartOptions= lines in Dart test runner. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add filename to exception. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/standalone/test_config.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/corelib/test_config.dart
diff --git a/tests/corelib/test_config.dart b/tests/corelib/test_config.dart
index 019ded9e3ebc2f60c3da5b14872f70993a6c8fff..a36ff7f57debd24b2feeac18ff3fba677b19ba86 100644
--- a/tests/corelib/test_config.dart
+++ b/tests/corelib/test_config.dart
@@ -61,9 +61,12 @@ class CorelibTestSuite {
if (configuration["component"] == "leg") {
args.add("--enable_leg");
}
- args.add(filename);
- List<List> optionsList = testOptions(filename);
+ var optionsFromFile = testOptions(filename);
+ List<List<String>> optionsList = optionsFromFile["vmOptions"];
+ List<String> dartOptions = optionsFromFile["dartOptions"];
+ args.addAll(dartOptions == null ? [filename] : dartOptions);
+
if (optionsList.isEmpty()) {
doTest(new TestCase(testName,
shellPath,
@@ -84,21 +87,32 @@ class CorelibTestSuite {
}
}
- List<List> testOptions(String filename) {
+ Map testOptions(String filename) {
RegExp testOptionsRegExp = const RegExp(@"// VMOptions=(.*)");
+ RegExp dartOptionsRegExp = const RegExp(@"// DartOptions=(.*)");
File file = new File(filename);
FileInputStream fileStream = file.openInputStream();
StringInputStream lines = new StringInputStream(fileStream);
List<List> result = new List<List>();
+ List<String> dartOptions;
String line;
while ((line = lines.readLine()) != null) {
Match match = testOptionsRegExp.firstMatch(line);
if (match != null) {
result.add(match[1].split(' ').filter((e) => e != ''));
}
+
+ match = dartOptionsRegExp.firstMatch(line);
+ if (match != null) {
+ if (dartOptions != null) {
+ throw new Exception(
+ 'More than one "// DartOptions=" line in test $filename');
+ }
+ dartOptions = match[1].split(' ').filter((e) => e != '');
+ }
}
- return result;
+ return {"vmOptions": result, "dartOptions": dartOptions};
}
void completeHandler(TestCase testCase) {
« no previous file with comments | « no previous file | tests/standalone/test_config.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698