Issue 8564044: Revert 110056 - Print Preview: Make print preview tab modal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8564044: Revert 110056 - Print Preview: Make print preview tab modal. (Closed)

Created:
9 years, 1 month ago by Lei Zhang

Modified:
9 years, 1 month ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, arv (Not doing code reviews), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 110056 - Print Preview: Make print preview tab modal. BUG=none TEST=none Review URL: http://codereview.chromium.org/8136027 TBR=thestig@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110059

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+696 lines, -501 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/printing/background_printing_manager.h	View	3 chunks	+20 lines, -0 lines	0 comments	Download
M	chrome/browser/printing/background_printing_manager.cc	View	4 chunks	+67 lines, -3 lines	0 comments	Download
M	chrome/browser/printing/print_preview_message_handler.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/printing/print_preview_message_handler.cc	View	3 chunks	+9 lines, -10 lines	0 comments	Download
M	chrome/browser/printing/print_preview_tab_controller.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/printing/print_preview_tab_controller.cc	View	8 chunks	+100 lines, -186 lines	0 comments	Download
M	chrome/browser/printing/print_preview_tab_controller_browsertest.cc	View	3 chunks	+169 lines, -59 lines	0 comments	Download
M	chrome/browser/printing/print_preview_tab_controller_unittest.cc	View	6 chunks	+62 lines, -14 lines	0 comments	Download
M	chrome/browser/printing/print_view_manager.h	View	3 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/printing/print_view_manager.cc	View	4 chunks	+20 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/print_preview/print_header.js	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/print_preview/print_preview.js	View	8 chunks	+39 lines, -22 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	4 chunks	+17 lines, -16 lines	0 comments	Download
M	chrome/browser/ui/browser_list_unittest.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/cloud_print_signin_dialog.cc	View	4 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/constrained_html_ui.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_data_source.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_handler.h	View	3 chunks	+12 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_handler.cc	View	15 chunks	+60 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_handler_unittest.cc	View	6 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_ui.h	View	5 chunks	+5 lines, -18 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_ui.cc	View	5 chunks	+8 lines, -55 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_ui_uitest.cc	View	1 chunk	+56 lines, -16 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_ui_unittest.cc	View	6 chunks	+3 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/webui/web_ui_browsertest.cc	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/test/base/test_tab_strip_model_observer.h	View	2 chunks	+9 lines, -12 lines	0 comments	Download
M	chrome/test/base/test_tab_strip_model_observer.cc	View	2 chunks	+4 lines, -24 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages