ppapi/tests/test_graphics2d: Implement TestScroll.

ppapi/tests/test_graphics2d: Implement TestScroll.

BUG=none
TEST=this is
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110153

[bbudge, 2011-11-15 01:34:10]

LGTM w / nits.

http://codereview.chromium.org/8564036/diff/1/ppapi/tests/test_graphics_2d.cc
File ppapi/tests/test_graphics_2d.cc (right):

http://codereview.chromium.org/8564036/diff/1/ppapi/tests/test_graphics_2d.cc...
ppapi/tests/test_graphics_2d.cc:400: const int image_w = 15, image_h = 23;
nit: x, y, width, height are the usual field names. So w-> width

http://codereview.chromium.org/8564036/diff/1/ppapi/tests/test_graphics_2d.cc...
ppapi/tests/test_graphics_2d.cc:420: // TC1, Scroll image to a free space.
Incorrect usage.
TC1 -> Test Case #1
Even better would be a descriptive short name, but that might be too hard for
some of these test cases.

http://codereview.chromium.org/8564036/diff/1/ppapi/tests/test_graphics_2d.cc...
ppapi/tests/test_graphics_2d.cc:422: // by specified amount. It's the area to
which the scroll is limited to. So if
nit: remove the dangling 'to' - you don't need it.

[polina, 2011-11-15 01:43:12]

http://codereview.chromium.org/8564036/diff/1/ppapi/tests/test_graphics_2d.cc
File ppapi/tests/test_graphics_2d.cc (right):

http://codereview.chromium.org/8564036/diff/1/ppapi/tests/test_graphics_2d.cc...
ppapi/tests/test_graphics_2d.cc:400: const int image_w = 15, image_h = 23;
On 2011/11/15 01:34:10, bbudge1 wrote:
> nit: x, y, width, height are the usual field names. So w-> width

Done.

http://codereview.chromium.org/8564036/diff/1/ppapi/tests/test_graphics_2d.cc...
ppapi/tests/test_graphics_2d.cc:420: // TC1, Scroll image to a free space.
Incorrect usage.
On 2011/11/15 01:34:10, bbudge1 wrote:
> TC1 -> Test Case #1
> Even better would be a descriptive short name, but that might be too hard for
> some of these test cases.

Done.

http://codereview.chromium.org/8564036/diff/1/ppapi/tests/test_graphics_2d.cc...
ppapi/tests/test_graphics_2d.cc:422: // by specified amount. It's the area to
which the scroll is limited to. So if
On 2011/11/15 01:34:10, bbudge1 wrote:
> nit: remove the dangling 'to' - you don't need it.

Done.

[polina, 2011-11-15 19:43:30]

+piman/dmichael
Need an LGTM from ppapi OWNER. Thanks!

[dmichael (off chromium), 2011-11-15 19:51:54]

lgtm

[polina, 2011-11-15 19:54:01]

On 2011/11/15 19:51:54, dmichael wrote:
> lgtm

Committed revision 110153.
Thanks, everybody!