Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8604)

Unified Diff: chrome/browser/sync/util/cryptographer_unittest.cc

Issue 8564032: [Sync] The cryptographer should be able to handle empty or old nigori nodes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Fix diff Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/util/cryptographer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/util/cryptographer_unittest.cc
diff --git a/chrome/browser/sync/util/cryptographer_unittest.cc b/chrome/browser/sync/util/cryptographer_unittest.cc
index 43a977122bd0700187baebba4c1a945d2ff4897c..73e389179a8ac578f5acaa0a8f5d34cbdb7dfcdd 100644
--- a/chrome/browser/sync/util/cryptographer_unittest.cc
+++ b/chrome/browser/sync/util/cryptographer_unittest.cc
@@ -207,7 +207,7 @@ TEST(CryptographerTest, NigoriEncryptionTypes) {
// Just set the sensitive types (shouldn't trigger any
// notifications).
ModelTypeSet encrypted_types(Cryptographer::SensitiveTypes());
- cryptographer.SetEncryptedTypesForTest(encrypted_types);
+ cryptographer.MergeEncryptedTypesForTest(encrypted_types);
cryptographer.UpdateNigoriFromEncryptedTypes(&nigori);
cryptographer2.UpdateEncryptedTypesFromNigori(nigori);
EXPECT_EQ(encrypted_types, cryptographer.GetEncryptedTypes());
@@ -225,11 +225,18 @@ TEST(CryptographerTest, NigoriEncryptionTypes) {
// Set all encrypted types
encrypted_types = syncable::GetAllRealModelTypes();
- cryptographer.SetEncryptedTypesForTest(encrypted_types);
+ cryptographer.MergeEncryptedTypesForTest(encrypted_types);
cryptographer.UpdateNigoriFromEncryptedTypes(&nigori);
cryptographer2.UpdateEncryptedTypesFromNigori(nigori);
EXPECT_EQ(encrypted_types, cryptographer.GetEncryptedTypes());
EXPECT_EQ(encrypted_types, cryptographer2.GetEncryptedTypes());
+
+ // Receiving an empty nigori should not reset any encrypted types or trigger
+ // an observer notification.
+ Mock::VerifyAndClearExpectations(&observer);
+ nigori = sync_pb::NigoriSpecifics();
+ cryptographer.UpdateEncryptedTypesFromNigori(nigori);
+ EXPECT_EQ(encrypted_types, cryptographer.GetEncryptedTypes());
}
TEST(CryptographerTest, EncryptEverythingExplicit) {
« no previous file with comments | « chrome/browser/sync/util/cryptographer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698