Report errors for default parameter values, issue 351

compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java

Index: compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java
diff --git a/compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java b/compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java
index e2525f6c8d056e14574002452d26385e79d77155..96297a6854d3b5a215587f717a99ee7d7b738591 100644
--- a/compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java
+++ b/compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java
@@ -10,9 +10,14 @@ import com.google.dart.compiler.SubSystem;
 public enum ParserErrorCode implements ErrorCode {
   ABSTRACT_MEMBER_IN_INTERFACE("Abstract members are not allowed in interfaces"),
   CATCH_OR_FINALLY_EXPECTED("catch or finally clause expected."),
+  DEFAULT_PARAMETER_ABSTRACT("Default values can not be specified in abstract method"),

[zundel, 2011/11/15 16:16:57]

DEFAULT_VALUE_NOT_IN_ABSTRACT_METHOD("Default value can ...

[scheglov, 2011/11/15 16:33:21]

Hm... I don't understand why to use "NOT" here and in other places (except of
operators and setter).
This is error, same as ABSTRACT_MEMBER_IN_INTERFACE, i.e. we   tell that
something is invalid - "default value for parameter in abstract method" is
invalid.

[zundel, 2011/11/15 16:36:46]

The convention in this file (with some exceptions) is that the enumeration name
matches at least the beginning default english translation of the message.  

To follow that convention to the letter, we should name it:
DEFAULT_VALUE_CAN_NOT_BE_SPECIFIED_IN_ABSTRACT

That seems a little long to me, so I shortened it.

[scheglov, 2011/11/15 16:45:58]

Done.

+  DEFAULT_PARAMETER_CLOSURE("Default values can not be specified in closure parameter"),

[zundel, 2011/11/15 16:16:57]

DEFAULT_VALUE_NOT_IN_CLOSURE("Default value can ...

+  DEFAULT_PARAMETER_INTERFACE("Default values can not be specified in signature of an interface method"),
+  DEFAULT_PARAMETER_TYPEDEF("Default values can not be specified in closure type definition"),

[zundel, 2011/11/15 16:16:57]

DEFAULT_VALUE_NOT_IN_TYPEDEF("Default value can ...

   DEFAULT_POSITIONAL_PARAMETER("Positional parameters cannot have default values"),
   DISALLOWED_ABSTRACT_KEYWORD("Abstract keyword not allowed here"),
   DISALLOWED_FACTORY_KEYWORD("Factory keyword not allowed here"),
+  EACH_PARAMETER_IS_REQUIRED("Each parameter should be required"),

[zundel, 2011/11/15 16:16:57]

NAMED_PARAMETER_NOT_ALLOWED("Named parameter is not allowed for operator or
setter method"

[scheglov, 2011/11/15 16:33:21]

Done.

   EXPECTED_ARRAY_OR_MAP_LITERAL("Expected array or map literal"),
   EXPECTED_CASE_OR_DEFAULT("Expected 'case' or 'default'"),
   EXPECTED_CLASS_DECLARATION_LBRACE("Expected '{' in class or interface declaration"),