Issue 8564026: Remove a DCHECK on stopping_ from StartRequestHelper. Since StartRequestHelper is now called on a...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8564026: Remove a DCHECK on stopping_ from StartRequestHelper. Since StartRequestHelper is now called on a... (Closed)

Created:
9 years, 1 month ago by robertshield

Modified:
9 years, 1 month ago

Reviewers:
ananta

CC:
chromium-reviews, amit, robertshield

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove a DCHECK on stopping_ from StartRequestHelper. Since StartRequestHelper is now called on a background thread, it does not make sense to DCHECK on a piece of state set on the main thread; stopping_ may well be set by the time the StartRequestHelper task is run. On teardown, we do block until pending background requests are handled, so it looks safe to remove the DCHECK. BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109967

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	chrome_frame/urlmon_url_request.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/8564026/1

9 years, 1 month ago (2011-11-14 21:22:39 UTC) #3

Change committed as 109967

Expand Messages | Collapse Messages