Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1582)

Unified Diff: views/bubble/bubble_delegate_unittest.cc

Issue 8564021: touchui: Fix a crash on consecutive volume/brightness bubble display. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/bubble/bubble_delegate.cc ('k') | views/bubble/bubble_frame_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/bubble/bubble_delegate_unittest.cc
diff --git a/views/bubble/bubble_delegate_unittest.cc b/views/bubble/bubble_delegate_unittest.cc
index 4064700636a084542c9eca71f2b70547caa9904d..f24c2c2095b7fe68aa82eb8a002f9e36e81c2928 100644
--- a/views/bubble/bubble_delegate_unittest.cc
+++ b/views/bubble/bubble_delegate_unittest.cc
@@ -14,7 +14,7 @@ typedef ViewsTestBase BubbleDelegateTest;
TEST_F(BubbleDelegateTest, CreateDelegate) {
BubbleDelegateView* bubble_delegate = new BubbleDelegateView(
NULL, BubbleBorder::NONE, SK_ColorGREEN);
- scoped_ptr<Widget> bubble_widget(
+ Widget* bubble_widget(
BubbleDelegateView::CreateBubble(bubble_delegate));
EXPECT_EQ(bubble_delegate, bubble_widget->widget_delegate());
EXPECT_EQ(bubble_widget, bubble_delegate->GetWidget());
@@ -25,7 +25,6 @@ TEST_F(BubbleDelegateTest, CreateDelegate) {
EXPECT_EQ(bubble_delegate->GetColor(), border->background_color());
bubble_widget->CloseNow();
- bubble_widget.reset();
RunPendingMessages();
}
« no previous file with comments | « views/bubble/bubble_delegate.cc ('k') | views/bubble/bubble_frame_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698