Issue 8564020: define OS_BSD on *BSD and replace the ifdefs to use that

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8564020: define OS_BSD on *BSD and replace the ifdefs to use that (Closed)

Created:
9 years, 1 month ago by Robert Nagy

Modified:
9 years, 1 month ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

define OS_BSD on *BSD and replace the ifdefs to use that BUG= TEST=compile Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109986

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -19 lines)			Patch
M	base/debug/debugger_posix.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	base/file_util_posix.cc	View	3 chunks	+6 lines, -7 lines	0 comments	Download
M	base/platform_file_posix.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	base/time_posix.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	build/build_config.h	View	2 chunks	+11 lines, -5 lines	0 comments	Download

Total messages: 6 (0 generated)

Mark Mentovai

Do you know that all of these work on all BSDs, or are you guessing ...

9 years, 1 month ago (2011-11-14 19:51:14 UTC) #2

Robert Nagy

On 2011/11/14 19:51:14, Mark Mentovai wrote: > Do you know that all of these work ...

9 years, 1 month ago (2011-11-14 22:06:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/8564020/1

9 years, 1 month ago (2011-11-14 22:15:56 UTC) #5

Change committed as 109986