Issue 8564008: [cros,login] Restore the focus after hidden auth extension has grabbed it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8564008: [cros,login] Restore the focus after hidden auth extension has grabbed it. (Closed)

Created:
9 years, 1 month ago by altimofeev

Modified:
9 years, 1 month ago

Reviewers:
xiyuan

CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[cros,login] Restore the focus after hidden auth extension has grabbed it. BUG=chromium-os:22862 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109944

Patch Set 4 : code review #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -18 lines)			Patch
M	chrome/browser/resources/chromeos/login/screen_gaia_signin.js	View	1 2 3	10 chunks	+64 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc	View		4 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

xiyuan

lgtm http://codereview.chromium.org/8564008/diff/3001/chrome/browser/resources/chromeos/login/screen_gaia_signin.js File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right): http://codereview.chromium.org/8564008/diff/3001/chrome/browser/resources/chromeos/login/screen_gaia_signin.js#newcode140 chrome/browser/resources/chromeos/login/screen_gaia_signin.js:140: }, nit: insert an empty line after

9 years, 1 month ago (2011-11-14 17:52:28 UTC) #2

altimofeev

9 years, 1 month ago (2011-11-14 20:21:45 UTC) #3

http://codereview.chromium.org/8564008/diff/3001/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

http://codereview.chromium.org/8564008/diff/3001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:140: },
On 2011/11/14 17:52:28, xiyuan wrote:
> nit: insert an empty line after

Done.

Expand Messages | Collapse Messages

Issue 8564008: [cros,login] Restore the focus after hidden auth extension has grabbed it. (Closed)

Description

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : nits #

Patch Set 4 : code review #

Messages