Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: vm/handles.h

Issue 8562008: Make the implicit constructor private for zone, handlescope and nohandlescope classes. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/allocation.h ('k') | vm/zone.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/handles.h
===================================================================
--- vm/handles.h (revision 1713)
+++ vm/handles.h (working copy)
@@ -20,7 +20,7 @@
// - allocation of handles in the current zone (Handle::AllocateZoneHandle).
// Handles allocated in this manner are destroyed when the zone is destroyed.
// - allocation of handles in a scoped manner (Handle::AllocateHandle).
-// A new scope can be started using HANDLESCOPE().
+// A new scope can be started using HANDLESCOPE(isolate).
// Handles allocated in this manner are destroyed when the HandleScope
// object is destroyed.
// Code that uses scoped handles typically looks as follows:
@@ -260,7 +260,7 @@
#if defined(DEBUG)
HandleScope* link_; // Link to previous scope.
#endif
- DISALLOW_COPY_AND_ASSIGN(HandleScope);
+ DISALLOW_IMPLICIT_CONSTRUCTORS(HandleScope);
};
// Macro to start a new Handle scope.
@@ -287,7 +287,7 @@
~NoHandleScope();
private:
- DISALLOW_COPY_AND_ASSIGN(NoHandleScope);
+ DISALLOW_IMPLICIT_CONSTRUCTORS(NoHandleScope);
};
#else // defined(DEBUG)
class NoHandleScope : public ValueObject {
@@ -296,7 +296,7 @@
~NoHandleScope() { }
private:
- DISALLOW_COPY_AND_ASSIGN(NoHandleScope);
+ DISALLOW_IMPLICIT_CONSTRUCTORS(NoHandleScope);
};
#endif // defined(DEBUG)
« no previous file with comments | « vm/allocation.h ('k') | vm/zone.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698