Adding Netflix performance measurement tests for dropped frames and CPU extrapolation

Adding Netflix performance tests, 
- To measure dropped frames/second.
- To calculate extrapolation of the utilization to play the test video.

Note: Moving Netflix helper functions to a separate class, so they can be reused easily for other Netflix tests.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111063

[dennis_jeffrey, 2011-11-21 22:45:10]

Thank you for fixing those style issues in netflix.py!

http://codereview.chromium.org/8562006/diff/6001/functional/netflix.py
File functional/netflix.py (right):

http://codereview.chromium.org/8562006/diff/6001/functional/netflix.py#newcode53
functional/netflix.py:53: def GetVideoDroppedFrames(self):
For this function and the function below, we should probably prefix the function
name with an underscore (to indicate that it should only be used by this class,
or subclasses of this class).

http://codereview.chromium.org/8562006/diff/6001/functional/netflix.py#newcode59
functional/netflix.py:59: return  int(self._pyauto.ExecuteJavascript(js))
remove one of the spaces after the word 'return'

http://codereview.chromium.org/8562006/diff/6001/functional/netflix.py#newcode59
functional/netflix.py:59: return  int(self._pyauto.ExecuteJavascript(js))
Maybe we should specify the window/tab index here.  You can let it be an
optional argument for the current function, defaulting to 0/0 (first window,
first tab).

http://codereview.chromium.org/8562006/diff/6001/functional/netflix.py#newcode67
functional/netflix.py:67: return  int(self._pyauto.ExecuteJavascript(js))
Same comments as line 59 above.

http://codereview.chromium.org/8562006/diff/6001/functional/perf.py
File functional/perf.py (right):

http://codereview.chromium.org/8562006/diff/6001/functional/perf.py#newcode48
functional/perf.py:48: from netflix import NetflixTestHelper
Move this up right before line 44, so that the application-specific helpers are
imported in alphabetical order ('netflix' comes before 'perf_snapshot').

http://codereview.chromium.org/8562006/diff/6001/functional/perf.py#newcode553
functional/perf.py:553: """Measures the Netflix video dropped frames. Runs for
60 secs."""
Clarify that this test measures the dropped frames per second (not the total
number of dropped frames).

http://codereview.chromium.org/8562006/diff/6001/functional/perf.py#newcode583
functional/perf.py:583: fraction_non_idle_time =\
nit: put a space right before the \

http://codereview.chromium.org/8562006/diff/6001/functional/perf.py#newcode586
functional/perf.py:586: extrapolation_value = fraction_non_idle_time *\
nit: put a space right before the \

http://codereview.chromium.org/8562006/diff/6001/functional/perf.py#newcode587
functional/perf.py:587: (total_video_frames +
total_dropped_frames)/total_video_frames
add spaces right before and right after the /

http://codereview.chromium.org/8562006/diff/6001/functional/perf.py#newcode634
functional/perf.py:634: """Measures the Youtube video dropped frames. Runs for
60 secs."""
Clarify that this test measures the dropped frames per second (not the total
number of dropped frames).

[rohitbm, 2011-11-22 00:57:09]

http://codereview.chromium.org/8562006/diff/6001/functional/netflix.py
File functional/netflix.py (right):

http://codereview.chromium.org/8562006/diff/6001/functional/netflix.py#newcode53
functional/netflix.py:53: def GetVideoDroppedFrames(self):
On 2011/11/21 22:45:10, dennis_jeffrey wrote:
> For this function and the function below, we should probably prefix the
function
> name with an underscore (to indicate that it should only be used by this
class,
> or subclasses of this class).

Done.

http://codereview.chromium.org/8562006/diff/6001/functional/netflix.py#newcode59
functional/netflix.py:59: return  int(self._pyauto.ExecuteJavascript(js))
On 2011/11/21 22:45:10, dennis_jeffrey wrote:
> remove one of the spaces after the word 'return'

Done.

http://codereview.chromium.org/8562006/diff/6001/functional/netflix.py#newcode59
functional/netflix.py:59: return  int(self._pyauto.ExecuteJavascript(js))
On 2011/11/21 22:45:10, dennis_jeffrey wrote:
> Maybe we should specify the window/tab index here.  You can let it be an
> optional argument for the current function, defaulting to 0/0 (first window,
> first tab).

Done.

http://codereview.chromium.org/8562006/diff/6001/functional/netflix.py#newcode67
functional/netflix.py:67: return  int(self._pyauto.ExecuteJavascript(js))
On 2011/11/21 22:45:10, dennis_jeffrey wrote:
> Same comments as line 59 above.

Done.

http://codereview.chromium.org/8562006/diff/6001/functional/perf.py
File functional/perf.py (right):

http://codereview.chromium.org/8562006/diff/6001/functional/perf.py#newcode48
functional/perf.py:48: from netflix import NetflixTestHelper
On 2011/11/21 22:45:10, dennis_jeffrey wrote:
> Move this up right before line 44, so that the application-specific helpers
are
> imported in alphabetical order ('netflix' comes before 'perf_snapshot').

Done.

http://codereview.chromium.org/8562006/diff/6001/functional/perf.py#newcode553
functional/perf.py:553: """Measures the Netflix video dropped frames. Runs for
60 secs."""
On 2011/11/21 22:45:10, dennis_jeffrey wrote:
> Clarify that this test measures the dropped frames per second (not the total
> number of dropped frames).

Done.

http://codereview.chromium.org/8562006/diff/6001/functional/perf.py#newcode583
functional/perf.py:583: fraction_non_idle_time =\
On 2011/11/21 22:45:10, dennis_jeffrey wrote:
> nit: put a space right before the \

Done.

http://codereview.chromium.org/8562006/diff/6001/functional/perf.py#newcode586
functional/perf.py:586: extrapolation_value = fraction_non_idle_time *\
On 2011/11/21 22:45:10, dennis_jeffrey wrote:
> nit: put a space right before the \

Done.

http://codereview.chromium.org/8562006/diff/6001/functional/perf.py#newcode587
functional/perf.py:587: (total_video_frames +
total_dropped_frames)/total_video_frames
On 2011/11/21 22:45:10, dennis_jeffrey wrote:
> add spaces right before and right after the /

Done.

http://codereview.chromium.org/8562006/diff/6001/functional/perf.py#newcode634
functional/perf.py:634: """Measures the Youtube video dropped frames. Runs for
60 secs."""
On 2011/11/21 22:45:10, dennis_jeffrey wrote:
> Clarify that this test measures the dropped frames per second (not the total
> number of dropped frames).

Done.

[dennis_jeffrey, 2011-11-22 01:08:19]

LGTM

Thank you!  I just have 2 minor nits to consider before submitting.

http://codereview.chromium.org/8562006/diff/11003/functional/netflix.py
File functional/netflix.py (right):

http://codereview.chromium.org/8562006/diff/11003/functional/netflix.py#newco...
functional/netflix.py:59: return int(self._pyauto.ExecuteJavascript(js,
tab_index, windex))
nit: "tab_index=tab_index, windex=windex"

(since those two arguments are optional, as defined by the ExecuteJavascript
function, we should name them explicitly).

http://codereview.chromium.org/8562006/diff/11003/functional/netflix.py#newco...
functional/netflix.py:67: return int(self._pyauto.ExecuteJavascript(js,
tab_index, windex))
Same comment as line 59 above.

[rohitbm, 2011-11-22 01:13:02]

Thanks Dennis!

On 2011/11/22 01:08:19, dennis_jeffrey wrote:
> LGTM
> 
> Thank you!  I just have 2 minor nits to consider before submitting.
> 
> http://codereview.chromium.org/8562006/diff/11003/functional/netflix.py
> File functional/netflix.py (right):
> 
>
http://codereview.chromium.org/8562006/diff/11003/functional/netflix.py#newco...
> functional/netflix.py:59: return int(self._pyauto.ExecuteJavascript(js,
> tab_index, windex))
> nit: "tab_index=tab_index, windex=windex"
Done.
> 
> (since those two arguments are optional, as defined by the ExecuteJavascript
> function, we should name them explicitly).
> 
>
http://codereview.chromium.org/8562006/diff/11003/functional/netflix.py#newco...
> functional/netflix.py:67: return int(self._pyauto.ExecuteJavascript(js,
> tab_index, windex))
> Same comment as line 59 above.
Done.