Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 8562002: Make the parser track the language mode instead of keeping its own harmony flag. (Closed)

Created:
9 years, 1 month ago by Steven
Modified:
9 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Make the parser track the language mode instead of keeping its own harmony flag. So far the parser had its own harmony flag to disable the harmony scoping feature when parsing native functions. With the introduction of the extended language mode this becomes unnecessary because native functions will never enter the extended mode. The parser can thus track FLAG_harmony_scoping and the language mode of the current scope to see if harmony features are allowed. The scanner and preparser have to keep their flag, because they can't use FLAG_harmony_scoping as it is not available for the preparser-process executable. This depends on: http://codereview.chromium.org/8417035/ Committed: http://code.google.com/p/v8/source/detail?r=10063

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -28 lines) Patch
M src/compiler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/parser.h View 3 chunks +4 lines, -2 lines 0 comments Download
M src/parser.cc View 14 chunks +13 lines, -19 lines 0 comments Download
M src/scanner.h View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Steven
PTAL.
9 years, 1 month ago (2011-11-14 06:48:56 UTC) #1
Jakob Kummerow
9 years, 1 month ago (2011-11-14 08:00:37 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698