Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 8562001: Fix typo in xkeyboard_unittests.cc. (Closed)

Created:
9 years, 1 month ago by Yusuke Sato
Modified:
9 years, 1 month ago
Reviewers:
mazda
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix typo in xkeyboard_unittests.cc. Without the CL, if the test runs with num lock enaled, it'll fail. BUG=None TEST=ran the test on Goobuntu with all 4 combinations of caps/num lock initial states (NumCaps=00,01,10,11). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M chrome/browser/chromeos/input_method/xkeyboard_unittest.cc View 1 chunk +22 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yusuke Sato
9 years, 1 month ago (2011-11-14 06:12:58 UTC) #1
mazda
lgtm
9 years, 1 month ago (2011-11-14 06:19:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/8562001/1
9 years, 1 month ago (2011-11-14 06:34:27 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-14 07:44:45 UTC) #4
Change committed as 109850

Powered by Google App Engine
This is Rietveld 408576698