Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 8561033: Pepper: Add remaining Flash-specific C++ Pepper wrappers to ppapi_cpp.gypi. (Closed)

Created:
9 years, 1 month ago by viettrungluu
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Add remaining Flash-specific C++ Pepper wrappers to ppapi_cpp.gypi. Also, remove flash_udp_socket.{cc,h}. They aren't actually used by Flapper right now (and any new usage should use udp_socket_private.{cc,h}). TEST=builds TBR=dmichael@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110981

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -124 lines) Patch
M ppapi/cpp/private/flash_menu.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/cpp/private/flash_menu.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/cpp/private/flash_net_connector.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/cpp/private/flash_net_connector.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D ppapi/cpp/private/flash_udp_socket.h View 1 chunk +0 lines, -40 lines 0 comments Download
D ppapi/cpp/private/flash_udp_socket.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M ppapi/ppapi_cpp.gypi View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
It might even build.
9 years, 1 month ago (2011-11-19 00:26:15 UTC) #1
yzshen1
lgtm
9 years, 1 month ago (2011-11-19 00:28:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/8561033/3001
9 years, 1 month ago (2011-11-21 17:53:32 UTC) #3
dmichael (off chromium)
lgtm
9 years, 1 month ago (2011-11-21 18:03:07 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-21 19:37:13 UTC) #5
Change committed as 110981

Powered by Google App Engine
This is Rietveld 408576698